feat: build logs virtualisation#1044
Open
AbhishekA1509 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces virtual scrolling for log rendering in the CICD history view, aiming to improve performance and user experience when handling large log datasets. The main changes include replacing the previous accordion-based log stage implementation, extracting and refactoring the log stage header, updating the scroll-to-top logic, and adding the
@tanstack/react-virtualdependency for efficient rendering.Log Rendering Virtualization and Refactoring:
@tanstack/react-virtual, significantly improving performance for large logs. This includes the addition of theLogLinecomponent and related constants for virtualization. (src/Shared/Components/CICDHistory/LogsRenderer.tsx, [1] [2]@tanstack/react-virtualpackage as a dependency to support virtualized lists. (package.json, package.jsonR116)Component Structure and Codebase Refactoring:
LogStageHeadercomponent, improving code organization and maintainability. (src/Shared/Components/CICDHistory/LogStageHeader.tsx, src/Shared/Components/CICDHistory/LogStageHeader.tsxR1-R104)LogStageAccordioncomponent, moving its header logic to the newLogStageHeaderand preparing for virtualization of log content. (src/Shared/Components/CICDHistory/LogStageAccordion.tsx, src/Shared/Components/CICDHistory/LogStageAccordion.tsxL1-L171)LogsRendererto useLogStageHeaderinstead ofLogStageAccordion. Also refactored utility imports for scrollable ancestor detection. (src/Shared/Components/CICDHistory/LogsRenderer.tsx, src/Shared/Components/CICDHistory/LogsRenderer.tsxL50-R63)Minor Improvements:
useScrollablehelper to use direct assignment (scrollTop = 0) for improved reliability. (src/Common/Helper.tsx, src/Common/Helper.tsxL894-R894)1.22.2-pre-1to1.22.2-beta-0to reflect the new beta release. (package.json, package.jsonL3-R3)Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist